erpnext icon indicating copy to clipboard operation
erpnext copied to clipboard

fix(SO, DN): only show permitted actions (backport #41384)

Open mergify[bot] opened this issue 9 months ago • 1 comments

Assume we have a user whose only permission is to read Sales Orders. We shouldn't display all the "Update Items" and "Create ..." buttons, because clicking them will just result in an error message and a frustrating user experience.

Before

All actions are available, regardless of permissions.

Bildschirmfoto 2024-05-08 um 16 21 10

After

Only permitted actions are displayed (none, in this case).

Bildschirmfoto 2024-05-08 um 16 20 45

The same applies to Delivery Note.


This is an automatic backport of pull request #41384 done by Mergify.

mergify[bot] avatar May 13 '24 13:05 mergify[bot]

Cherry-pick of c29d95537185d909612103b65573242a91ef0d70 has failed:

On branch mergify/bp/version-14-hotfix/pr-41384
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit c29d955371.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/selling/doctype/sales_order/sales_order.js

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of 418bdc1dcc0c8c8eaaa6555b3689436515270c7c has failed:

On branch mergify/bp/version-14-hotfix/pr-41384
Your branch is ahead of 'origin/version-14-hotfix' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 418bdc1dcc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/public/js/controllers/transaction.js

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/stock/doctype/delivery_note/delivery_note.js

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] avatar May 13 '24 13:05 mergify[bot]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar May 31 '24 01:05 stale[bot]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar Jun 18 '24 05:06 stale[bot]

:tada: This issue has been resolved in version 14.70.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

frappe-pr-bot avatar Jul 03 '24 05:07 frappe-pr-bot