erpnext
erpnext copied to clipboard
frappe
fix(general-ledger): hide zero effect rows
Create a sales invoice and a credit note (unrelated ones) Reconcile both and check the ledger with Show Net Values in Party Account checked
Before:
After:
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
I faced this same issue today. In my opinion, creation of additional Journal Entry should be avoided if possible on payment reconciliation where it's possible. Journal Entry every time to reconcile is overkill.
It created a new journal entry for reconciling invoice with other journal entry in my scenario.
Journal Entry every time to reconcile is overkill.
This is very true. Also, we often have a hard time convincing users about these system generated JVs and the impact it brings on the general ledger report. Often customers/suppliers can't compare our statement with their ones cause of these extra entries.
Create a sales invoice and a credit note (unrelated ones) Reconcile both and check the ledger with Show Net Values in Party Account checked
Before:
After:
@rtdany10 In the before screenshot, is the Sales Invoice and Return made in company currency or in a foreign currency?
It created a new journal entry for reconciling invoice with other journal entry in my scenario.
@vorasmit That shouldn't be the case. Are the invoice and journal in company currency or foreign currency?
@ruthra-kumar, I'll dig deeper. Actually it's run programmatically in my case. Thank you for the pointers.
I did a retest and have come up with a way to replicate the issue. Reported here: https://github.com/frappe/erpnext/issues/42302
@rtdany10 In the before screenshot, is the Sales Invoice and Return made in company currency or in a foreign currency?
In company currency itself.
@rtdany10 In the before screenshot, is the Sales Invoice and Return made in company currency or in a foreign currency?
In company currency itself.
In that case, that Journal itself looks invalid. It is supposed to have values in Debit and Credit. From the screenshot, it doesn't look like it.
Is this replicable?
@rtdany10 In the before screenshot, is the Sales Invoice and Return made in company currency or in a foreign currency?
In company currency itself.
In that case, that Journal itself looks invalid. It is supposed to have values in Debit and Credit. From the screenshot, it doesn't look like it.
Is this replicable?
The journal has values, but when you tick "Show Net Value in Party Account" checkbox in the filters, it will show zero
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
@ruthra-kumar please check
System generated Credit / Debit Journals are the ones that primarily have net effect of '0'. There is a new checkbox - 'Ignore System Generated Credit / Debit Notes', added specifically to ignore them on General Ledger, which will handle the above case.
@rtdany10 Do you still need this change?