erpnext icon indicating copy to clipboard operation
erpnext copied to clipboard

fix(return): set default return warehouse

Open blaggacao opened this issue 1 year ago • 6 comments

This captures the case of manual modifications to the return and ensures that by default, the correct return warehouse will be set

Context

  • Create a dn return of a packaged good of milk and marmalade
  • Return only the milk

To do this:

  • remove the package from the return
  • manually add the milk; set negative count

With this patch, the milk will be returned to the correct default sales return warehouse.

blaggacao avatar Mar 25 '24 15:03 blaggacao

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar Apr 10 '24 02:04 stale[bot]

No this should not be closed or go stale, but merged as a fix or even hotfix!!

blaggacao avatar Apr 10 '24 06:04 blaggacao

@deepeshgarg007 @rohitwaghchaure Can you help to review?

In my opinion, this should be a hotfix due to the impact of not having that field set during (partial) return operations in bundled product scenarios.

blaggacao avatar Apr 10 '24 06:04 blaggacao

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar Apr 28 '24 10:04 stale[bot]

ping

blaggacao avatar Apr 28 '24 12:04 blaggacao

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar May 15 '24 03:05 stale[bot]

@rohitwaghchaure This was closed by mistake, it is not fixed yet. Please remove the stale artist. Thanks! :handshake:

blaggacao avatar May 22 '24 15:05 blaggacao

@ruthra-kumar can you please reopen this? This is a an importan fix for Return Merchandise Management when working with product bundles.

blaggacao avatar Jun 04 '24 10:06 blaggacao