fix(pe): set contact fields
Context
Notifications generally depend on the contact_* set of fields.
Payment Entries have a stump implementation that lets you select a contact.
However, unlike every other transactional document, they don't acquire the default contact, if set.
This makes communication automations which depend on the default contact property difficult to implement, because the contact_* set of fields are not available.
Proposed Solution
- [x] like other tx documents, let PEs aquire default contact data, too
- [x] if there's no default contact, nothing happens
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.13%. Comparing base (
b9a8dd4) to head (02c78c5). Report is 13 commits behind head on develop.
:exclamation: Current head 02c78c5 differs from pull request most recent head 98c7f44. Consider uploading reports for the commit 98c7f44 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #39748 +/- ##
===========================================
- Coverage 60.44% 60.13% -0.31%
===========================================
Files 758 758
Lines 71521 71009 -512
===========================================
- Hits 43228 42704 -524
- Misses 28293 28305 +12
| Files | Coverage Δ | |
|---|---|---|
| ...xt/accounts/doctype/payment_entry/payment_entry.py | 79.98% <100.00%> (-0.52%) |
:arrow_down: |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
This is still desireable.