erpnext icon indicating copy to clipboard operation
erpnext copied to clipboard

fix: update exploded items on root bom, fixes #38469

Open casesolved-co-uk opened this issue 1 year ago • 3 comments

The root BOM exploded items needs updating for the same reason that the cost of the root BOM is updated, child BOMs may have changed.

Fixes https://github.com/frappe/erpnext/issues/38469

https://github.com/frappe/erpnext/pull/39244 does NOT fix the issue

NOTE: set_maintain_stock_for_bom_item.py must have been run for BOM update to work which is a v14 patch

version-15-hotfix version-14-hotfix version-13-hotfix

casesolved-co-uk avatar Jan 29 '24 22:01 casesolved-co-uk

Your failed test appears to be caused by enqueue_replace_bom(boms=frappe._dict(current_bom=old_bom, new_bom=new_bom.name)) which won't have been run by the time the comparison is made.

Please fix your test.

https://github.com/frappe/erpnext/actions/runs/7703614884/job/20994365062?pr=39629

casesolved-co-uk avatar Jan 30 '24 12:01 casesolved-co-uk

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar Feb 15 '24 02:02 stale[bot]

.

casesolved-co-uk avatar Feb 15 '24 02:02 casesolved-co-uk

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar Mar 02 '24 11:03 stale[bot]