fix: calculate depreciation properly on asset sale entry and scrap entry

[anandbaburajan]

Support issue with all the details: https://frappe.io/app/issue/ISS-22-23-02096. Now the system correctly calculates asset's depreciation for the days till it is scraped or sold.

[codecov[bot]]

Codecov Report

Merging #32226 (c1e3498) into develop (d5359bb) will decrease coverage by 0.18%. The diff coverage is 84.28%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32226      +/-   ##
===========================================
- Coverage    64.00%   63.81%   -0.19%     
===========================================
  Files          817      817              
  Lines        58172    58179       +7     
===========================================
- Hits         37232    37129     -103     
- Misses       20940    21050     +110     

Impacted Files	Coverage Δ
erpnext/controllers/accounts_controller.py	84.49% <ø> (+0.12%)	:arrow_up:
erpnext/assets/doctype/asset/depreciation.py	85.71% <81.96%> (-1.57%)	:arrow_down:
...xt/accounts/doctype/sales_invoice/sales_invoice.py	81.90% <100.00%> (+0.03%)	:arrow_up:
...ctype/asset_capitalization/asset_capitalization.py	92.82% <100.00%> (ø)
...eport/item_variant_details/item_variant_details.py	31.32% <0.00%> (-53.02%)	:arrow_down:
...tch_item_expiry_status/batch_item_expiry_status.py	67.92% <0.00%> (-24.53%)	:arrow_down:
...wise_balance_history/batch_wise_balance_history.py	67.79% <0.00%> (-23.73%)	:arrow_down:
...ext/accounts/report/balance_sheet/balance_sheet.py	36.36% <0.00%> (-21.82%)	:arrow_down:
...saction/incorrect_balance_qty_after_transaction.py	90.69% <0.00%> (-9.31%)	:arrow_down:
...pnext/setup/doctype/sales_partner/sales_partner.py	65.21% <0.00%> (-4.35%)	:arrow_down:
... and 27 more

[nabinhait]

@AnandBaburajan Can you please add a proper description in the PR? It's not good to add an internal support issue link for future reference because community devs don't have access to it.

[anandbaburajan]

@AnandBaburajan Can you please add a proper description in the PR? It's not good to add an internal support issue link for future reference because community devs don't have access to it.

Ah, done.

[nabinhait]

@Mergifyio backport version-14-hotfix

[mergify[bot]]

backport version-14-hotfix

✅ Backports have been created

• #32398 fix: calculate depreciation properly on asset sale entry and scrap entry (backport #32226) has been created for branch version-14-hotfix