erpnext icon indicating copy to clipboard operation
erpnext copied to clipboard

feat: Added Quotation Comparison to Buying

Open mymi14s opened this issue 2 years ago • 2 comments

Description

This PR added Quotation Comparison to ERPNEXT. Quotation comparison is a feature that can be used to compare supplier created quotations for Request for Quotation. It is executed in the following order:

  • Request for Quotation created with suppliers selected.
  • Suppliers fill quotations online or created from desk on behalf of the suppliers.
  • Quotation Comparison is fired up.

Quotation Comparison can be used to analyse quotations based on the following

  1. Total cost from single supplier.(lowest to Highest).
  2. Total Cost from multiple suppliers (each item analysed, lowest price selected from each supplier).
  3. Earliest Delivery.

Once quotation is accepted and submitted, Purchase Order can be created directly from the document to one or more suppliers based on how the items were selected by the comparison calculator.

mymi14s avatar Sep 06 '22 16:09 mymi14s

Codecov Report

Merging #32107 (c0c6fc1) into develop (da43a5e) will decrease coverage by 0.05%. The diff coverage is 0.00%.

:exclamation: Current head c0c6fc1 differs from pull request most recent head a9412b7. Consider uploading reports for the commit a9412b7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32107      +/-   ##
===========================================
- Coverage    63.97%   63.91%   -0.06%     
===========================================
  Files          817      821       +4     
  Lines        58161    58212      +51     
===========================================
- Hits         37207    37206       -1     
- Misses       20954    21006      +52     
Impacted Files Coverage Δ
...ison_sheet_quotation/comparison_sheet_quotation.py 0.00% <0.00%> (ø)
..._quotation_item/comparison_sheet_quotation_item.py 0.00% <0.00%> (ø)
...ion_comparison_sheet/quotation_comparison_sheet.py 0.00% <0.00%> (ø)
...ison_sheet_item/quotation_comparison_sheet_item.py 0.00% <0.00%> (ø)
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) :arrow_down:
...e_sales_analytics/supplier_wise_sales_analytics.py 59.01% <0.00%> (-31.15%) :arrow_down:
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) :arrow_down:
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-23.73%) :arrow_down:
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) :arrow_down:
.../report/stock_projected_qty/stock_projected_qty.py 85.52% <0.00%> (-2.64%) :arrow_down:
... and 33 more

codecov[bot] avatar Sep 07 '22 05:09 codecov[bot]

Linter will be fixed, please ignore the updated and add the review changes so I can see the actual issues, thank you.

mymi14s avatar Sep 11 '22 06:09 mymi14s

@mymi14s Closing this until a GIF/Video is attached. Please add and reopen

deepeshgarg007 avatar Sep 26 '22 12:09 deepeshgarg007

@deepeshgarg007 a video has been attached.

mymi14s avatar Sep 26 '22 12:09 mymi14s

@deepeshgarg007 linter test passed.

mymi14s avatar Oct 01 '22 18:10 mymi14s

@deepeshgarg007 is the video attached enough for the description or is there more that is required. The linter seem to be annoying.

mymi14s avatar Oct 04 '22 08:10 mymi14s

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar Oct 19 '22 15:10 stale[bot]

This is a very cool feature. I guess we got to relook at this @mymi14s @deepeshgarg007.

mujeerhashmi avatar Mar 23 '23 01:03 mujeerhashmi

It was ignored 🙁.

mymi14s avatar Mar 23 '23 05:03 mymi14s