erpnext icon indicating copy to clipboard operation
erpnext copied to clipboard

Allow Item Templates in Work Order Items

Open djpalshikar opened this issue 2 years ago • 3 comments

Item Variants can be a part of the items tables, however, when BOM items are fetched to be a part of the Work Order items, item variants were being filtered out. The filtering out does not serve a purpose. Having Item variants in BOMs allows for template like behaviour.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

djpalshikar avatar Sep 01 '22 13:09 djpalshikar

Codecov Report

Merging #32049 (75396c0) into develop (b05fdb2) will decrease coverage by 0.10%. The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32049      +/-   ##
===========================================
- Coverage    63.42%   63.31%   -0.11%     
===========================================
  Files          813      813              
  Lines        57607    57607              
===========================================
- Hits         36535    36473      -62     
- Misses       21072    21134      +62     
Impacted Files Coverage Δ
erpnext/manufacturing/doctype/bom/bom.py 87.95% <ø> (ø)
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-37.51%) :arrow_down:
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-16.84%) :arrow_down:
...em_wise_sales_register/item_wise_sales_register.py 50.45% <0.00%> (-12.28%) :arrow_down:
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-8.19%) :arrow_down:
...ck/report/cogs_by_item_group/cogs_by_item_group.py 89.74% <0.00%> (-7.70%) :arrow_down:
erpnext/accounts/party.py 77.71% <0.00%> (-4.46%) :arrow_down:
erpnext/assets/doctype/asset/asset.py 81.92% <0.00%> (-0.83%) :arrow_down:
...t/accounts/report/general_ledger/general_ledger.py 67.23% <0.00%> (-0.35%) :arrow_down:
erpnext/projects/doctype/project/project.py 51.45% <0.00%> (-0.33%) :arrow_down:
... and 18 more

codecov[bot] avatar Sep 04 '22 13:09 codecov[bot]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

stale[bot] avatar Sep 19 '22 18:09 stale[bot]

@rohitwaghchaure please review this. It will go a long way, trying to handle a very wide variety of BOM.

djpalshikar avatar Sep 20 '22 09:09 djpalshikar