erpnext
erpnext copied to clipboard
fix: Scrap Asset Accounting Dimensions
While scrapping assets, accounting dimensions are not passed to the journal entry, so I added them to fix the issue.
Codecov Report
Merging #31949 (749bc56) into develop (f41d150) will increase coverage by
0.03%
. The diff coverage is100.00%
.
Additional details and impacted files
@@ Coverage Diff @@
## develop #31949 +/- ##
===========================================
+ Coverage 63.96% 63.99% +0.03%
===========================================
Files 817 817
Lines 58159 58167 +8
===========================================
+ Hits 37199 37223 +24
+ Misses 20960 20944 -16
Impacted Files | Coverage Δ | |
---|---|---|
...xt/accounts/doctype/sales_invoice/sales_invoice.py | 81.87% <ø> (ø) |
|
...ext/accounts/report/trial_balance/trial_balance.py | 0.00% <ø> (ø) |
|
...trial_balance_for_party/trial_balance_for_party.py | 0.00% <ø> (ø) |
|
...ctype/asset_capitalization/asset_capitalization.py | 92.82% <ø> (ø) |
|
erpnext/manufacturing/doctype/bom/bom.py | 87.95% <ø> (ø) |
|
...t/accounts/report/general_ledger/general_ledger.py | 67.57% <100.00%> (-0.69%) |
:arrow_down: |
erpnext/assets/doctype/asset/depreciation.py | 87.28% <100.00%> (+0.61%) |
:arrow_up: |
...eorder_level/itemwise_recommended_reorder_level.py | 88.88% <0.00%> (-3.71%) |
:arrow_down: |
...e/asset_value_adjustment/asset_value_adjustment.py | 87.95% <0.00%> (-3.62%) |
:arrow_down: |
...pnext/stock/doctype/delivery_note/delivery_note.py | 73.24% <0.00%> (-2.71%) |
:arrow_down: |
... and 28 more |
@Mergifyio backport version-14-hotfix
backport version-14-hotfix
✅ Backports have been created
-
#32376 fix: Scrap Asset Accounting Dimensions (backport #31949) has been created for branch
version-14-hotfix
Somewhat related, please add dimensions on asset capitalization too.