erpnext-shipping icon indicating copy to clipboard operation
erpnext-shipping copied to clipboard

Create better Exceptioninfo ;)

Open thejoe8495 opened this issue 1 year ago • 1 comments

https://github.com/frappe/erpnext-shipping/blob/090196287afca3e886182d3818a6564095c02f81/erpnext_shipping/erpnext_shipping/doctype/letmeship/letmeship.py#L64 The error messageblock shows only error, it would be better to return the complete JSON from the server. In our case the return was an undocumented: { "errorCode": 400, "errorMessage": "Your request is not properly formatted, please refer to the documentation guide for sample requests" } The created JSON is valid but Letmeship don't want to accept it. We can reproduce it in the swagger ui of Letmeship and create an Ticket on Letmeship to find out where is the Problem n the JSON. https://api.letmeship.com/v1/swagger-ui.html#/Available%20Services/getAvailableServicesUsingPOST

thejoe8495 avatar Mar 09 '24 21:03 thejoe8495

I didn't check, but you should probably find the complete error in the Error Log DocType.

Btw, I did test the available services with LetMeShip and it should work fine in the latest release.

barredterra avatar Mar 09 '24 22:03 barredterra