Optimizing the Group Creation Flow

[Dieule26]

1. Reconsider the Invite button, as we create groups without needing to send notifications or requests to the people added to the group, so the Invite button is not really necessary.
2. When I add multiple people to the group, before clicking the Invite button, I can only select 'Clear All' and cannot remove an individual person at this step
3. When clicking on ..., the only available action is to "Remove". So, why not put the 'trash' icon outside, allowing users to perform the action quickly? Let's improve the group creation flow to make it as quick and simple for users as possible

[uhrjun]

1. without needing to send notifications

This is subject to change, notifications are going to be added, hence the explicit invite.

2. When I add multiple people to the group, before clicking the Invite button, I can only select 'Clear All' and cannot remove an individual person at this step

This is a valid issue, it's also present in ShareDialog, GroupDetails and NewGroup. File a new issue to keep an easier track of this. Something like "Better user adding flow". Since it's all the same component.

3. When clicking on ...a, the only available action is to "Remove". So, why not put the 'trash' icon outside, allowing users to perform the action quickly?

Yeah, that's exactly how it used to be. The reason it's two clicks right now is that there's no confirmation dialogue. So the two clicks serve as a pseudo confirm action.

I'll look into changing this, maybe a confirmation action isn't actually needed in NewGroupDialog anyway since the group is not created till the primary button is clicked.

[uhrjun]

https://github.com/frappe/drive/commit/da0147cd68ba87f2c25b9a3a6daa7f601457a12f changes the dropdown to a button

[Dieule26]

I have updated it, but there are a few issues afterward.

1. Using the word 'kick' doesn't seem very appropriate.
2. When I select 'Kick', the user is removed from the user list, and I can't add that person back into the group. I can only add that person to the group when I exit and create a new one. Please look at the images below to understand the issue clearly.

[Dieule26]

@uhrjun Thank you for your response. Please also read the comments here :>>

[uhrjun]

When I select 'Kick', the user is removed from the user list, and I can't add that person back into the group. I can only add that person to the group when I exit and create a new one

Yeah, that's a bug. The list should refresh.

[safwansamsudeen]

We no longer have groups, instead having teams.