drive icon indicating copy to clipboard operation
drive copied to clipboard

Users with "Can Edit" Permisson can't delete files

Open Delte opened this issue 1 year ago • 1 comments

user with "Can Edit" permission can't delete files in the folders, either lift restriction at https://github.com/frappe/drive/blob/c83894d13a06d8fcf81042a1074d0ba5499e17ee/drive/api/files.py#L947 or have to make a new permissions for Delete&Restore

Delte avatar Mar 07 '24 18:03 Delte

That's currently by design. Even if a user can write to a file, they shouldn't be able to delete it entirely. If the file in question is inside a shared folder, that's not owned by them. They can "delete" the file with can-edit permission on the parent folder. The outcome then is that the file is just moved to the home folder of the owner.

The point is, at any given point in time. Only the person who uploaded the file should be able to truly delete it. Or of course the admin can do it.

or have to make a new permissions for Delete&Restore

Will circle back to this if more need for this arises.

uhrjun avatar Mar 09 '24 05:03 uhrjun