Wanted to give time wise restriction to the files shared

[precihole]

So we have a scenario in which we share our designs with a client, and we wanted to limit their access to files for a set length of time, as well as the number of times they could open the same file.

[Zahidshakil]

Any development on it

[uhrjun]

Yeah been a bit busy with everything else in the project. This isn't hard to do, will just push an initial implementation this coming week. Will add a date picker in the advanced sharing settings. And a background job that just checks for expired docshares and invalidates them

[Dieule26]

When will this feature be completed? Will it be included in the next upcoming release?

[uhrjun]

Here's the UX so far

https://github.com/user-attachments/assets/1e1d68b3-2414-460e-8c9f-aba748a82eb2

Some thoughts:

• This currently removes all sharing, public, organization, users, and user groups.
• Rolled this out to develop but limited only to date-based restrictions, need to work on the UX and fix any initial issues that might pop up relating to broken permission trees. Then I can just simply add time.
• Need to address special cases for shared folders that contain files and folders from multiple users. Once the invalidation date is reached. Should file owners still be able to access their files that are inside the shared folder? It might make sense to allow only the owner, after the date has passed, though I'm unsure.
• Should this setting only apply to public share and organization share, while completely ignoring user and user groups. Since the latter are considered more explicit collaborators.
• For time selection, will mostly stick to hourly intervals. Need to add intervals to the Frappe UI dateTimePicker