datatable icon indicating copy to clipboard operation
datatable copied to clipboard

Fix header and footer in rtl body direction

Open ahmed-madi opened this issue 6 years ago • 6 comments

Header and footer don't scroll when the body is in rtl direction, and this is because of the different value of scrollLeft in different browsers when the direction is rtl, also - sign should be inside the Template string like this ${-scrollLeft} to be calculated properly in case of rtl body direction because Firefox calculates the value of the scrollLeft in negative when the direction is rtl so translateX need a positive value to move as expected. this pull request fix these issues.

Thank you

ahmed-madi avatar Jan 20 '19 02:01 ahmed-madi

i test it locally it works fine with me .. but when i use it inside frappe bench and goo to node module and build it doesn't work ?

ahmadRagheb avatar Feb 24 '19 12:02 ahmadRagheb

@netchampfaris what do you think?

ahmadRagheb avatar Feb 26 '19 14:02 ahmadRagheb

@ahmed-madi there is issue when change the col size it do the ltr not rtl adjustment

ahmadRagheb avatar Mar 02 '19 09:03 ahmadRagheb

when change the size of columns it goes to LTR not RTL

Please give scenario with steps to reproduce

ahmed-madi avatar Mar 02 '19 10:03 ahmed-madi

@ahmed-madi i try to make some columns width changes so in RTL the same direction as LTR in width addition .. it should go to right not left

ahmadRagheb avatar Mar 10 '19 20:03 ahmadRagheb

@ahmadRagheb Could You fix the Conflicting files?

mhbu50 avatar May 11 '19 23:05 mhbu50