bench icon indicating copy to clipboard operation
bench copied to clipboard

feat(config): Add RHEL 8 compatibility

Open deajan opened this issue 2 years ago • 2 comments

closes #1041

What type of a PR is this?

  • [X] Bug Fix

This PR improves RHEL 8 and clones detection (was limited to CentOS 7). Also fixes supervisord / nginx services cannot be reloaded unless already started, which would end up with an error stopping production setup. Replaces service('supervisor', 'reload') with existing supervisor_reload() function which handles different service names (eg supervisor on debian likes and supervisord on RHEL likes).

  • [X] Have you followed the guidelines in our Contributing document?
  • [X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [X] Have you lint your code locally prior to submission?
  • [X] Have you successfully run tests with your changes locally?
  • [X] Does your commit message have an explanation for your changes and why you'd like us to include them?
  • [N/A] Docs have been added / updated
  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Did you modify the existing test cases? If yes, why?

deajan avatar May 16 '22 15:05 deajan

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 30 '22 12:05 sonarqubecloud[bot]

Hey @deajan, can you resolve the conflicts and update the branch?

gavindsouza avatar Jul 27 '22 09:07 gavindsouza

@deajan Thank you for your contribution. Could you kindly update your code so that it becomes compatible with the latest Bench version? It appears that numerous changes have occurred since your previous fix. Thank you anyway.

alaahariri avatar Apr 03 '23 07:04 alaahariri