bench icon indicating copy to clipboard operation
bench copied to clipboard

Easy Install Script: Upgrade wkhtmltox to 0.12.6 for all architectures

Open ceefour opened this issue 3 years ago • 2 comments

Issue: Easy Install

Do the checklist before filing an issue:

  • [x] Did you retain the logfile (path of logfile is shared while the script is run)? We definitely need the logfile to debug any easy install related issues.
  • [x] Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome

Distro Information (Required)

All

Command Run (Required)

Log File (Required)

Screenshots

Additional context

wkhtmltox 0.12.6 was released Jun 11, 2020.

https://github.com/frappe/bench/pull/1077 requires 0.12.6 because it is the first version that supports Arm64.

Continuation of #897.

Possible Solution

If @gavindsouza approves, I can make PR for this. Note: 0.12.6 does not have checksums.

ceefour avatar Oct 03 '20 07:10 ceefour

I have a couple of questions about this.

  1. Have you been able to setup Frappe on arm64 devices? Is adding wkhtmltox support the only thing that's pending for doing so?
  2. Have you tested print formats with wkhtmltox 0.12.6 (patched qt)? Can you show screenshots of working formats too?

gavindsouza avatar Oct 27 '20 09:10 gavindsouza

@gavindsouza :

  1. Yes. We've been running Erpnext 13.beta.4 (Frappe 13.beta.5) on Arm64 / AWS Graviton2 without any Arm64-related issues:

image

And I'm saying this we're using a lot of features....... Accounts, Subscriptions, Sales Invoice, Payment Entry, Payroll Entry, Leads, Web Forms, Customer, Contact, REST API integration, Inbox, Email, Email Template, and also our own custom app...

  1. Yup, enjoy: :+1:

image

So congratulations, good job for making a very complex ERP app portable...! I'm really happy that it's possible to run ERPNext on Arm64 with minor tweaks (and after these patches get accepted, ERPNext will be compatible out of the box!) ^_^

Oh and I think @tcort and wkhtmltox guys will be happy to know that their new release 0.12.6 enabled ERPNext to support Arm64 !

ceefour avatar Oct 27 '20 16:10 ceefour