Franziskus Kiefer

Results 353 comments of Franziskus Kiefer

Most cases should be covered by what's doing in #393. Let's assess if this is still needed when that's done.

So this is a regression from #743? @W95Psp why aren't there tests catching something like this?

@W95Psp @paulmure what's the state here? It looks to me like the PR only needs a review?

@W95Psp what's the state on this? I haven't seen this in a while.

@W95Psp what's the state here?

> 1. Do we think testing just the key generation and values of the other context fields is enough or do we need to have `encryptions` and `exports` for each...

> 2\. The `direct_ctx` check against the `key`, `nonce`, and `exporter_secret` are failing still. (lines 155-157) Hm, when you enable the `hpke-test-prng` feature, you see those tests fail as well....

I had another look. The key schedule context doesn't seem to be right.