usbpicprog icon indicating copy to clipboard operation
usbpicprog copied to clipboard

Compilation fail

Open alx741 opened this issue 8 years ago • 2 comments

I'm on Archlinux, and unable to compile upp_wx

doing: $ ./autogen.sh $ ./configure $ make

fails on make with this output: http://pastebin.com/JHUmSf0F

alx741 avatar Jun 15 '16 15:06 alx741

You seem to use wxwidgets 2.9. Please upgrade to the stable 3.x version

fransschreuder avatar Jun 15 '16 15:06 fransschreuder

Thanks for the fast response.

I was using wxwidgets 3.0.2, but fail to compile so i tried with 2.9.4.

I went back to 3.0.2 and still failing: http://pastebin.com/hC5zarPD

alx741 avatar Jun 15 '16 15:06 alx741

I guess this is closed after this commit in 2018:

commit 1a541cf069b40e42d69bacc4fbb1db577b5cd458
Author: Frans Schreuder <[email protected]>
Date:   Mon Jan 22 21:15:24 2018 +0100

    Fixed compile on ubuntu 17.10

diff --git a/trunk/upp_wx/src/hexfile.cpp b/trunk/upp_wx/src/hexfile.cpp
index b7fbe374..8fb8d610 100644
--- a/trunk/upp_wx/src/hexfile.cpp
+++ b/trunk/upp_wx/src/hexfile.cpp
@@ -96,7 +96,7 @@ bool HexFile::open(PicType* picType, const char* filename)
     // for info about the HEX file format see:
     // http://en.wikipedia.org/wiki/Intel_HEX
 
-    if (fp==NULL)
+    if (!fp.is_open())
     {
         wxLogError(_("Could not open Hex file..."));
         return false;
@@ -336,7 +336,7 @@ bool HexFile::saveAs(PicType* picType, const char* filename)
     char txt[256];
     int address;
 
-    if (fp==NULL)
+    if (!fp.is_open())
     {
         wxLogError(_("Could not open Hex file for writing..."));
         return false;

fransschreuder avatar Oct 11 '23 12:10 fransschreuder