react-slidedown icon indicating copy to clipboard operation
react-slidedown copied to clipboard

Make all classnames overwritable

Open loominade opened this issue 5 years ago • 1 comments

Since I am using BEM in my project, I am required to overwrite all the classnames defined in SlideDown. So I added these two new props:

import 'mything.css'

<SlideDown
  className='mything'
  transitioningClassName='mything--transitioning'
  closedClassName='mything--closed'
  closed={isMyThingClosed?}
>

If ommited, everything behaves as it did.

loominade avatar Nov 18 '20 11:11 loominade

Nice addition. Wouldn't it be easier to read if it's passed via an object? Like so:

import 'mything.css'

<SlideDown
  className='mything'
  classNames={{
    transitioning: 'mything--transitioning',
    closed: 'mything--closed',
  }}
  closed={isMyThingClosed?}
>

JPeer264 avatar Dec 10 '20 21:12 JPeer264