TengYao Chi comments

Results 38 comments of


                                            TengYao Chi

KAFKA-17042: The migration docs should remind users to set "broker.id.generation.enable" when adding broker.id

Hi @showuon I have adjust the description based on your feedback, PTAL

KAFKA-17042: The migration docs should remind users to set "broker.id.generation.enable" when adding broker.id

Hi @chia7712 , @showuon I have added a reminder about potential failures, PTAL 🐧

KAFKA-17032: NioEchoServer should generate meaningful id instead of incremental number.

Hi @chia7712 I have make some changes based on feedback, PTAL 😄

KAFKA-17032: NioEchoServer should generate meaningful id instead of incremental number.

Hi @gharris1727, I have make some changes based on feedbacks, PTAL 😺

KAFKA-17032: NioEchoServer should generate meaningful id instead of incremental number.

Hi @chia7712 , I have merged the latest trunk, PTAL

[TEST] Test new implementation of ConsumerRecords#records(String) in CI

Hi @chia7712, Here are the benchmark results after adding `Blackhole` to prevent JVM optimization. The new implementation is slightly slower, which indicates that the previous version was indeed being optimized...

[TEST] Test new implementation of ConsumerRecords#records(String) in CI

Hello @chia7712 , I have write another implementation which is almost same as original logic. The different of new one is that it filter the `TopicPartition` in the `ConcatenatedIterable` to...

[TEST] Test new implementation of ConsumerRecords#records(String) in CI

Hi @chia7712 I have refactor the method, PTAL 🐱

[TEST] Test new implementation of ConsumerRecords#records(String) in CI

Hi @chia7712 I have both iterate test and init test, PTAL ``` # JMH version: 1.37 # VM version: JDK 17.0.11, OpenJDK 64-Bit Server VM, 17.0.11+9-LTS # VM options: #...

[TEST] Test new implementation of ConsumerRecords#records(String) in CI

Hi @chia7712 I have make some refactors based on comment, PTAL 😃