luajit-lang-toolkit icon indicating copy to clipboard operation
luajit-lang-toolkit copied to clipboard

AST validation: syntax description for Tables is wrong

Open stepelu opened this issue 8 years ago • 2 comments

According to ast-validate.lua, Tables are expected to be described in terms of the array_entries, hash_keys and hash_values properties.

However, lua-ast.lua generates Tables as with a single keyvals property which is essentially a list of pairs.

As such the validation of AST trees containing Tables is currently failing.

stepelu avatar Nov 15 '15 19:11 stepelu

Hi Stefano,

of course this need to be fixed. The validator for the table was broken when I merged some proposition of @gnois. We forgot to update the ast-validate stuff.

franko avatar Nov 16 '15 20:11 franko

I am not sure it can be fixed without updating the various check functions, do you confirm?

stepelu avatar Nov 20 '15 20:11 stepelu