vsmartcard
vsmartcard copied to clipboard
frankmorgner
WIP: support for Belgian eID cards
This includes code that is also in #103; should probably be considered with that in mind.
When parsing the XML file found in virtualsmartcard/belpic-example-data/belpic.xml, the official eID software (found in Fedict/eid-mw here on github, in case you want to test) detects it as a belpic-compliant card (with invalid data). The XML format is the same format that the current development tooling for the Belgian electronic ID card already uses, so it's not completely useless -- but one major TODO item is still to make the BelpicOS class parse from a config file, like the nPA implementation already does, rather than externalizing that to other tooling. Nevertheless, it's not completely useless provided it's used with that other tooling.
Please let me know whether this is going in a direction you would consider acceptable.
I absolutely consider your code acceptable! Your code concentrates on your card without changing (and potentially breaking) much of the other stuff.
From a user's perspective it's a bad idea to have too many ways of doing the same thing (e.g. for initializing the card with data). But if your tooling is used elsewhere it's definitely good to have this available as an option for the virtual smart card as well.
Is there something "useful" one can do with the implementation in its current state?
Do you actually want to merge the code or did you only want to get this feedback?
On Tue, Jun 20, 2017 at 02:48:11PM -0700, Frank Morgner wrote:
I absolutely consider your code acceptable! Your code concentrates on your card without changing (and potentially breaking) much of the other stuff..
Good :-)
From a user's perspective it's a bad idea to have too many ways of doing the same thing (e.g. for initializing the card with data). But if your tooling is used elsewhere it's definitely good to have this available as an option for the virtual smart card as well.
Yeah, that was my thinking too. I think it makes sense to have something that looks similar to how you did the nPA thing, for people who want to play with this but aren't really developing for the Belgian eID, but at the same time also integrate with the tooling that already exists.
Is there something "useful" one can do with the implementation in its current state?
I need to do some more tests, but I believe it can be used for read-only operations already, yes.
The "run eid-viewer and see what breaks" test seemed somewhat successful, at least, and is wat triggered this pull request. It gets corrupt data with the example XML data (which I now found out is a broken one, I'll fix that later), but at least it doesn't say "I don't recognize this card" anymore like it did a few days ago.
Do you actually want to merge the code or did you only want to get this feedback?
Well, I want to finish the SAM work first, but eventually, yeah. This is done on billable time (at low priority), so expect it in a few weeks or so.
-- Could you people please use IRC like normal people?!?
-- Amaya Rodrigo Sastre, trying to quiet down the buzz in the DebConf 2008 Hacklab
I got side-tracked by other things that had way higher priority. Those are almost finished by now, and then I plan to take this up again.
Thanks for your interest :)
