Frank Morgner

Results 528 comments of Frank Morgner

The PIV driver is one of the most complex card drivers in OpenSC. It already has a ton of undocumented *features* such as influential enviroment variables or configuration switches, it...

This PR is not yet ready. Maybe my language was too harsh or my review was not clear enough. There are two structural things that require some bigger refactoring -...

Back around in 2010, I have argued that separating SM into a standalone module doesn't make sense because it always requires input from a card driver level. The only use...

One bigger question got lost with pushing some new commits: Is the internal PIV cache needed at all? In my tests, I never got any meaningful cache hit (except for...

With respect to the technical support, I don't see a problem with having that question here. It's not like someone is suggesting to include a broken random number generator 🤓....

slot->token->loginRequired is set in libp11 https://github.com/OpenSC/libp11/blob/master/src/p11_slot.c#L516 The PKCS#11 flag CKF_LOGIN_REQUIRED is set here https://github.com/OpenSC/OpenSC/blob/master/src/pkcs11/framework-pkcs15.c#L1207 pkcs15_init_slot is called by pkcs15_create_slot, which only seems to be called without an authentication object, if...

> type becomes "des" instead of "rsa" inside `do_generate_skey()` when using `--insecure` for some reasons and this triggers this error, see the screenshot of gdb: > > ![image](https://user-images.githubusercontent.com/15802528/172151644-c3fadb58-a65a-4048-9b73-8fc80f4abe5c.png) > >...

Actually you need to find out why do_generate_key returns SC_ERROR_INVALID_ARGUMENTS, because do_generate_key is for RSA, do_generate_skey is for symmetric keys.

why is create_key failing? a debug log might also help...

It happens here: ``` P:189168; T:0x139884082702144 12:00:09.453 [pkcs15-init] pkcs15-rtecp.c:308:rtecp_create_key: called P:189168; T:0x139884082702144 12:00:09.453 [pkcs15-init] pkcs15-lib.c:1519:sc_pkcs15init_generate_key: Cannot generate key: create key failed: -1300 (Invalid arguments) ```