Frank Greco Jr

Results 37 comments of Frank Greco Jr

Yes. Btw I think there are a few other instances of this. We can apply the same fix as they are found. Btw, since this is a breaking change. I'll...

I meant breaking change for this repo, the operator (breaking change for the CRD types). We should probs audit the rest of the process in `apis/fluentbit` where this same issues...

@benjaminhuo don't we need to decide on what the plan is to your comment before that PR is merged? Anyone that pulls `latest` will now run into errors and must...

With this change being merged, the following will happen (please correct me if I am wrong) ``` 1. User has existing CRDs using this plugin 2. User updates the version...

Thanks so much! My recommendation is that we use the next CRD version for this `v1alpha3` (I think). However, I think we batch up some more changes into that version....

> We might release v1alpha3 CRDs maybe after adding the custom plugin CRD mentioned in https://github.com/fluent/fluent-operator/issues/301#issuecomment-1152362843 Perhaps then to get started we can do this ``` - you create a...

@benjaminhuo Thank you! I'm at Snowflake Summit this week but I'll PR against that branch (along with all of the new v1alpha3 boilerplate) when I get a chance.

Yea something like that. The number of types will change based on the longest key. I can take a look at this.

A potential solution is to add logic to the wrapper that ``` 1. Catches FluentBit failures and increments a prometheus metric 2. Run a sidecar that implements the Pods readiness/liveness...

@benjaminhuo could you point me to where the watcher code lives?