doctrine-query-specification icon indicating copy to clipboard operation
doctrine-query-specification copied to clipboard

Drop return typehint on QuerySpecification

Open Brammm opened this issue 3 years ago • 3 comments

Addresses #12

Brammm avatar Jun 15 '22 13:06 Brammm

@Brammm looks good! Can you add a testcase that validates support?

frankdejonge avatar Jun 15 '22 13:06 frankdejonge

@frankdejonge I just noticed how you circumvented the whole "isNullreturns string" thing in the FieldIsNotNull test:

return $expr->andX($expr->isNotNull("{$rootAlias}.{$this->field}"));

So I could either change that test to return the string (and make sure everything still works) or drop this PR and do the same in my project...

Brammm avatar Jun 17 '22 07:06 Brammm

@Brammm both work for me :)

frankdejonge avatar Jun 19 '22 09:06 frankdejonge