doctrine-query-specification icon indicating copy to clipboard operation
doctrine-query-specification copied to clipboard

Too narrow typehint on QueryConstraint::asQueryConstraint (?object)

Open Brammm opened this issue 2 years ago • 0 comments

The QueryConstraint::asQueryConstraint method has an optional object as typehint. I assume this is because most ExpressionBuilder methods return some kind of Doctrine\ORM\Query\Expr class. However Expr::isNull and Expr::isNotNull return a string, not an object.

Should this typehint be made broader to simply mixed? I can make a PR if you'd like.

Brammm avatar Jun 15 '22 13:06 Brammm