ember-data-save-relationships icon indicating copy to clipboard operation
ember-data-save-relationships copied to clipboard

Reason for disabling embedded relationships

Open v-ken opened this issue 8 years ago • 5 comments

Hi Frank,

Was wondering if there was a reason for disabling embedded relationships?

https://github.com/frank06/ember-data-save-relationships/blob/master/addon/index.js#L42,L43

// do not allow embedded relationships
delete serialized.data.relationships;

Some of my relationships needs that data in order to be saved on the server side. I tried to remove that line and the add-on seems to be working fine. Was wondering if I could safely do this?

v-ken avatar May 28 '16 15:05 v-ken

Reason: I was lazy to add the test. Does it actually work? Do you think you could contribute a test? If not at some point I'll try myself

frank06 avatar May 28 '16 18:05 frank06

Thanks Frank. Will try to add a test for it.

v-ken avatar May 29 '16 01:05 v-ken

We've got a PR for this - testing on our code base then we will submit. Adds tests and fixes code.

BryanCrotaz avatar Jun 14 '16 22:06 BryanCrotaz

@BryanCrotaz Thanks! Sorry I didn't have the chance to get around to this.

v-ken avatar Jun 16 '16 04:06 v-ken

PR #8

BryanCrotaz avatar Jun 16 '16 08:06 BryanCrotaz