no-title-bar icon indicating copy to clipboard operation
no-title-bar copied to clipboard

Published 20 hours ago • verified publisher icon franglais125

Will break with gnome-shell 3.30

Open eddy-geek opened this issue 6 years ago • 7 comments

Extension does not start on Fedora 29 Beta, gnome-shell 3.30 RC (3.29.91-1)

Current Behavior

Following errors are printed:

TypeError: global.screen is undefined
appMenu is null
TypeError: global.screen is undefined

Possible Solution

See https://github.com/home-sweet-gnome/dash-to-panel/issues/434 and fix https://github.com/micheleg/dash-to-dock/pull/770

Basically global.screen moved to global.display, while all the workspace related features have been moved to the WorkspaceManager and displays are managed by DisplayManager.

Also the built-in extensions update commit

Your Environment

  • gnome-shell version: 3.29.91-1
  • distribution : Fedora 29 Beta

eddy-geek avatar Sep 01 '18 09:09 eddy-geek

Actually the work for this has been done already. I can confirm git master works with 3.29.91.

What is missing is the update of the official gnome-shell store.

eddy-geek avatar Sep 08 '18 18:09 eddy-geek

Has this been uploaded to Gnome Extensions, there's apparently nothing waiting in the review queue for this.

uniquePWD avatar Oct 14 '18 08:10 uniquePWD

  • 1, crashes on GNOME Shell 3.30.1 gnome-shell[22270]: Extension "[email protected]" had error: TypeError: global.screen is undefined

aspidxt avatar Oct 16 '18 12:10 aspidxt

Hopefully @trustin can make a pull request with the changes he proposed in #97 so they can merged.

uniquePWD avatar Oct 16 '18 12:10 uniquePWD

I release the diff I published in #97 under public domain as defined in https://creativecommons.org/publicdomain/zero/1.0/deed.en

Please feel free to take it and do whatever you wanna do, e.g. sending a new PR or merging it into your repository.

trustin avatar Oct 16 '18 13:10 trustin

Done. Thank you @trustin

uniquePWD avatar Oct 16 '18 13:10 uniquePWD

Does anyone know what @franglais125 is planning to do with this extension?

uniquePWD avatar Oct 22 '18 16:10 uniquePWD