no-title-bar icon indicating copy to clipboard operation
no-title-bar copied to clipboard

Broken in GNOME 3.32.0

Open aulospl opened this issue 5 years ago • 14 comments

The extension loads but no longer works on GNOME 3.32.0.

aulospl avatar Mar 16 '19 15:03 aulospl

It loads, but only works partially. The buttons in the top bar are present and work (minimize and close), I can drag down from the panel to grab the window, but title bars are no longer hidden. Looking Glass says there hasn't been any error message, journalctl confirms.

Gnome Shell 1:3.32.0+15+gb7d79a5f0-1 NTB v9-7-g7e14934 Arch Linux

Wuestengecko avatar Mar 17 '19 13:03 Wuestengecko

I get nothing in my LG and following in my journal:

bře 17 15:30:02 dixcall gnome-shell[2050]: JS ERROR: Could not load extension [email protected]~: Error: uuid "[email protected]" from metadata.json does not match directory name "[email protected]~"
                                            createExtensionObject@resource:///org/gnome/shell/misc/extensionUtils.js:196:15
                                            _loadExtension@resource:///org/gnome/shell/misc/extensionUtils.js:239:25
                                            scanExtensions/<@resource:///org/gnome/shell/misc/extensionUtils.js:250:13
                                            collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:25:17
                                            scanExtensions@resource:///org/gnome/shell/misc/extensionUtils.js:249:9
                                            _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:326:5
                                            enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:334:9
                                            _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:365:9
                                            init@resource:///org/gnome/shell/ui/extensionSystem.js:373:5
                                            _initializeUI@resource:///org/gnome/shell/ui/main.js:222:5
                                            start@resource:///org/gnome/shell/ui/main.js:124:5
                                            @<main>:1:31

meridius avatar Mar 17 '19 14:03 meridius

In my case the option "Show buttons for all windows" do not work and a title bar is still not hidden as well. image image

satriani-vai avatar Mar 17 '19 14:03 satriani-vai

Having the same issue here (with Antergos). I noticed that some apps, like Firefox, now have no title bar by default (the window's close/minimize/iconify controls are on the level of tabs). Same for the settings, and gnome apps (which I think were like this even before, on 3.30). Some other apps, like Atom or QT Creator, still have the title bar, which is not hidden.

sonicdebris avatar Mar 24 '19 17:03 sonicdebris

Apparently the Unite extension figured it out for 3.32. Perhaps the same "fix" will work for this extension.

skewty avatar Mar 25 '19 18:03 skewty

Well, kinda. For now I moved to Unity extension, but it has this issue https://github.com/hardpixel/unite-shell/issues/74 that apparently comes from its approach (they had it for a long time). I never had this issue with no-title-bar, so personally I would hope for a fix that works with multiple screens. I don't know if copy-pasting their solution would not fetch their issues.

MateuszKubuszok avatar Mar 26 '19 15:03 MateuszKubuszok

I tried switching to Unite & noticed a pretty substantial increase in CPU usage. I'd be happier if this was fixed :grinning:

jmcomets avatar Apr 06 '19 05:04 jmcomets

High CPU usage seems to be caused by the top icon component. After disabling that, CPU usage looks normal for me. However, unite messes up the top panel (e.g. hardpixel/unite-shell#100), and it has too many features that I don't want, so I'd rather use no-title-bar as well. :stuck_out_tongue_winking_eye:

bryango avatar Apr 06 '19 11:04 bryango

I have tried to modify the extension to make it work. It kinda works but not really. The bar is removed for the focused window when the shell is reloaded and that's all, I don't know why.

I have replaced the cmd in decoration.js in the method _setHideTitleBar.

let prop
let value

if (useMotifHints) {
    const flag = '0x2, 0x0, %s, 0x0, 0x0';

    prop = '_MOTIF_WM_HINTS';
    value = hide
        ? flag.format(Meta.is_wayland_compositor() ? '0x2': '0x0')
        : flag.format('0x1');
} else {
    prop = '_GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED';
    value = hide ? '0x1' : '0x0';
}

let cmd = ['xprop', '-id', winXID, '-f', prop, '32c', '-set', prop, value];

Ludonope avatar Apr 08 '19 04:04 Ludonope

High CPU usage seems to be caused by the top icon component. After disabling that, CPU usage looks normal for me. However, unite messes up the top panel (e.g. hardpixel/unite-shell#100), and it has too many features that I don't want, so I'd rather use no-title-bar as well.

After some experiments I find that the side effects of unite can be eliminated by simply commenting out its stylesheet.css. Now unite seems quite usable to me!

bryango avatar Apr 08 '19 06:04 bryango

I've been using https://github.com/velitasali/GTKTitleBar/ on 3.32 without any issues.

diabolicle avatar Apr 11 '19 07:04 diabolicle

I've been using https://github.com/velitasali/GTKTitleBar/ on 3.32 without any issues.

Such a simple and beautiful implementation, thank you for the heads up.

uniquePWD avatar Apr 11 '19 09:04 uniquePWD

GTKTitleBar is fine so far, but one thing is really missing for me: Closing an application is painful. If have to minimize it and then click the X. I also appreciate the white and black list function of no title bar.

So +1 for getting this thing running in 3.32.

weeman1337 avatar May 21 '19 13:05 weeman1337

its working for terminal with this option settings set org.gnome.Terminal.Legacy.Settings headerbar false

dkiyatkin avatar Jun 26 '19 23:06 dkiyatkin