vite-ssr icon indicating copy to clipboard operation
vite-ssr copied to clipboard

feat: add support for @vueuse/head versions >1.0.0

Open ManneW opened this issue 1 year ago • 8 comments

The purpose of the changes in this PR is to add support for the consumer of the library to use newer versions of the @vueuse/head library, while still retaining compatibility with lower versions.

To have reliable test cases to ensure both versions are working, the structure of how the test fixtures are provided access to the vite-ssr build is slightly modified.

Feel free to ask any questions or add feedback about the implementation and I'll be happy to assist.

ManneW avatar Mar 27 '23 15:03 ManneW

Fixes #195

thomasowow avatar Mar 28 '23 08:03 thomasowow

I think this also fixes #194 :slightly_smiling_face:

ManneW avatar Mar 31 '23 07:03 ManneW

Any idea when this can be merged?

SuzanaK avatar Apr 13 '23 10:04 SuzanaK

@frandiox the package @vueuse/head gets deprecated in the coming months.

See here: vueuse/head

In the coming months, the @vueuse/head package will be deprecated. If you're setting up this package on a new project, you should use the @unhead/vue package directly.

phlegx avatar May 19 '23 14:05 phlegx

Thanks a lot for this PR, and sorry for the late response! Not sure if we need backwards compatibility for 0.x or we can just require 1.x (or better, @unhead/vue) 🤔 Will try to come back to this in the weekend 🙏

frandiox avatar May 24 '23 01:05 frandiox

Thanks a lot for this PR, and sorry for the late response! Not sure if we need backwards compatibility for 0.x or we can just require 1.x (or better, @unhead/vue) thinking Will try to come back to this in the weekend pray

Make sure to undo/update the change from #195 before this PR is merged.

thomasowow avatar May 24 '23 06:05 thomasowow

@frandiox thank you so much! If dependencies like @unhead/vue are upgraded, we should also upgrade @rollup/plugin-replace to v5.x. Like described in #201 warnings related to @rollup/plugin-replace can be solved.

phlegx avatar May 26 '23 10:05 phlegx

Hi! News from here? I can help to test the new planned version.

phlegx avatar Jun 08 '23 08:06 phlegx