Fran Dios

Results 178 comments of Fran Dios

>Instead of changing isModuleReference, you can make it look up in the map if the string is in the map. Then inside resolveModuleMetaData and getModuleKey you can look it up...

>You can plop in a isModuleReference check in the typeof type === 'function' branch. It's probably fine to assume that the string won't be a "long string" if it's used...

@natew I just updated this plugin with the latest changes in upstream. Not sure if it will fix your issues, though, but you can give it a try. Other than...

>Is this a regression? I think the code hasn't changed at all in the past 2 months and I haven't noticed any flash 🤔 In any case, I'm about to...

@nicofierro94 Have you tried with the new [`global` mode](https://shopify.dev/custom-storefronts/hydrogen/framework/css-support#using-css)? It's possible there's a flash in development due to HMR + CSS injection but I think there shouldn't be any flash...

> @frandiox — would https://github.com/Shopify/hydrogen/pull/2175 fix this? Unfortunately, I think it's unrelated. Will need to debug this one separately.

Hi! Thanks for reporting this. It seems the sitemap [works in our demo-store](https://hydrogen.shop/sitemap.xml) so it might not be related to Oxygen but something in old versions of the demo-store. I've...

@beppek It turns out Oxygen does not serve `/sitemap.xml` and `/robots.txt` for public preview deployments to avoid indexing issues. It should work for the production deployment (when using a custom...

Would it work without the underscores? ``` src ├── App.server.jsx └── routes ├── product.server.jsx ├── collection.server.jsx ├── featured.server.jsx ├── featured/index.server.jsx ├── featured/thing.server.jsx ``` Where `featured.server.jsx` renders `` and everything in...

This seems to be fixed when the main Tailwind file is imported in `App.server.jsx` instead of `index.html` (so that server side is aware of styles).