MenuIcons: default file icon may show up in the wrong menu-items

[Yaron10]

@francostellari,

One example: Encoding -> Character sets.

If detecting : is the best way of setting a menu-item as "file name", how about checking if it's under "Recently Closed Files" or Window? Too complex? Not worth the extra code?

Thank you for looking into it.

[francostellari]

@Yaron10 tracking the menu is more work than I want to do. Currently it's looking for : with a space after. I will add a filter to ignore : with a space before.

[Yaron10]

@francostellari,

I will add a filter to ignore : with a space before.

This wouldn't solve the problem.

1. : is wrong. There shouldn't be a leading space.
2. There are other menu-items with :. -> North European.
3. I recently added : to a menu-item in my localization file.

Thank you.

[Yaron10]

@francostellari,

I haven't been notified of the fix. Thank you for your work.

With v2.06, the default icon appears in the "Recently Closed Files" list, but does NOT show up under Window. Is that intentional?

[francostellari]

@Yaron10 sine you did not accept filtering out : because you had your personal modification, I filtered on the menu index. File has index 0 and Windows has index 12 in English. I have not idea why it would not be in other locales.

[Yaron10]

@francostellari,

I filtered on the menu index.

👍

File has index 0 and Windows has index 12 in English.

It does not work in English either. Isn't Window 11?

Thank you.

[Yaron10]

Please update here if and when you fix it. I'd appreciate that.