Francois Laithier

Results 41 comments of Francois Laithier

👋 I read the previous comments in this issue and there are a lot of linked issues, can someone clarify what we need internal engineers for at this time? Sounds...

I thought we already had a PR in progress for this? I may have confused with something else though. Anyway, pretty straightforward change, let's get this done 🚀

#53820 is a backend blocker, checking off.

Not an emergency, that's a bug with the merge checks.

I tested and was able to repro on dev too. I'm not aware of any changes in Integration-Server, though in this case I imagine the Onyx updates should come from...

Hmm sounds like a fluke, doesn't make sense that this change would affect perf.

Ah, yes it was this checklist: https://github.com/Expensify/App/issues/48791 - iirc the automation failed on that day. Anyway, looks like there's a follow-up PR https://github.com/Expensify/App/pull/49490 for this?

Sounds good, I like the proposed solution. When we generate the setup link in the backend, we have to store some details about it in the policy, so if you...

I can repro on Web on staging, looking now. Not sure if it's a backend or NewDot blocker yet, let's keep both labels for now.

This is a backend bug caused by https://github.com/Expensify/Web-Expensify/pull/44662/, removing the NewDot blocker label.