Franck
Franck
I have been trying to implement the following approach: - new method createSampleListing under scripts/helpers/create-sample-listing.js gets called by build.js - createSampleListing instantiates an Origin object then call Origin.marketplace.createListing Code is...
Good catch. Seems we should add some checks to cap rating between 1-5 in origin-js when writing and reading review data from IPFS. BTW, what are we deciding on rating...
I tested my suggestion on both Node and Chrome browser. But I agree more testing on different type of browsers would make me feel more confident... I'm actually not clear...
Related to #441
CC @tomlinton
Disclosure: I'm very new to this project... so pardon me if I missed or misunderstood things :) Here are my thoughts, in no particular order, on the proposal by @allenday...
Sorry for the super long turnaround time :( I finally had time to take a first pass at reviewing. Overall I like the simplicity and the addition of the invariants....
Old PR. Closing.