Plugin.NFC icon indicating copy to clipboard operation
Plugin.NFC copied to clipboard
verified publisher icon franckbour

Updated For MAUI - Maui support #97

Open pavan7parekh opened this issue 3 years ago • 6 comments

Library is updated to support .Net MAUI

Description of Change

I make change to migrate .NetStandard 2 to .Net 6. and also update deprecated methods of CoreNFC.

Bugs Fixed

  • Related to issue # Maui support #97

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Changed:

  • <Project Sdk="MSBuild.Sdk.Extras/3.0.44"> => <Project Sdk="Microsoft.NET.Sdk">
  • tag.GetNFCMiFareTag() != null => tag.Type == CoreNFC.NFCTagType.MiFare
  • tag.GetNFCIso7816Tag() != null => tag.Type == CoreNFC.NFCTagType.AsNFCIso7816Tag
  • tag.GetNFCIso15693Tag() != null => tag.Type == CoreNFC.NFCTagType.AsNFCIso15693Tag
  • tag.GetNFCFeliCaTag() != null => tag.Type == CoreNFC.NFCTagType.FeliCa

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • [x] Has tests (if omitted, state reason in description)
  • [x] Has samples (if omitted, state reason in description)
  • [ ] Rebased on top of master at time of PR
  • [x] Changes adhere to coding standard
  • [x] Updated documentation

pavan7parekh avatar Jul 14 '22 10:07 pavan7parekh

@pavan7parekh great work! 2 things, you removed backwards compatibility with Xamarin forms old projects by removing former standard isn’t it? Also, for this file src/Plugin.NFC/iOS/NFC.iOS.cs can you only commit the changes that you made and not the white space and indentation changes?

saamerm avatar Jul 14 '22 13:07 saamerm

@saamerm We can not make it for backwards compatibility with Xamarin old projects. Actually, To make it compatible for MAUI we need change the Project SDK "MSBuild.Sdk.Extras/3.0.44" to "Microsoft.NET.Sdk". and that's why it is not compatible for Xamarin.

pavan7parekh avatar Jul 14 '22 17:07 pavan7parekh

@pavan7parekh check out this conversation https://twitter.com/Saamerm/status/1547650109181087745 and this example https://github.com/smstuebe/xamarin-fingerprint/commit/90ba2eda57fd5fd4bfb3ffe439fbd5bad690e8e0

saamerm avatar Jul 14 '22 20:07 saamerm

@pavan7parekh, @saamerm I fixed the backward compatibility with XF and also added a new sample for MAUI if you want to check out.

franckbour avatar Jul 24 '22 12:07 franckbour

@franckbour Awesome! Thank You

pavan7parekh avatar Jul 24 '22 12:07 pavan7parekh

Hi @franckbour,

When my PR will approve and merge? I have to update my project with plugin.nfc nuget package.

pavan7parekh avatar Jul 28 '22 21:07 pavan7parekh