franciscolourenco
Is it possible that this could cause Ghostty to hang on long running processes?
That repository doesn't seem to be available. Maybe it is private?
Ah yes it is, I apologize. https://mitchellh.com/ghostty @mitchellh might be able to add you if you want. It's his awesome NEW terminal. With done installed fish hangs after running tree .
Hello! I'd be happy to add you @franciscolourenco but I consider any functionality that works in other terminals and not mine a bug with my own terminal 😄 So I don't think this is a done bug. I'll invite you anyways though!
Sorry @franciscolourenco you can't see our issue but I've tracked this down to an upstream issue: https://github.com/julienXX/terminal-notifier/issues/301 Specifically from my thread:
Okay I've installed
donewith fish and I can reproduce this only withterminal-notifierinstalled. I can actually reproduce this purely withterminal-notifier:# This hangs! $ echo "hello" | terminal-notifier -title "Hello" -sender "com.mitchellh.ghostty"It looks like
terminal-notifieritself is hanging for some reason.
I'm not sure why it hangs with the Ghostty ID. But it appears based on the previous issue this isn't unique. I don't see any smoking guns in logs anywhere.
Btw, I was surprised to see that done doesn't use OSC9 or OSC777 (native terminal desktop notifications) supported by Kitty, WezTerm, foot, and iTerm2. Ghostty also supports these. That would make done not require any dependencies and it wouldn't have to shell out either.
Their usage:
OSC 9
OSC 9 ; <body> ST
OSC 777
OSC 777 ; notify ; <title> ; <body> ST
@mitchellh unfortunately this doesn't work when the process is in a detached tmux session or the shell is otherwise not interactive
@mitchellh unfortunately this doesn't work when the process is in a detached tmux session or the shell is otherwise not interactive
True! But if the shell is interactive and it's not tmux, it does work, which I feel would still be pretty common?
I'd say if you were thinking about implementing @mitchellh ideas we could keep this open @franciscolourenco otherwise I think we can close it.
@blacktop will have to follow up on OSC 9 and OSC 777 in a different thread. I'll leave this open for now just for reference. Thanks!
I just started running into this issue. I'm using iTerm and tmux. Not sure why it just started happening, I've been using done for several years now with no issue. I was able to reproduce directly with terminal-notifier, so it seems like the problem is indeed over there. That issue seems specific to the -sender option, so I was able to work around by overriding the notification command in my fish config like this:
set -U __done_notification_command "echo \$message | terminal-notifier -title \$title"
The terminal-notifier issue linked above is still open, so it might be good to document this workaround or just keep the issue open for anyone else who runs into it (although I would recommend editing the title since we know this isn't specific to Ghostty).
