Franci Penov

Results 90 comments of Franci Penov

We are not using firmware 1.5, all the firmware changes have been made in firmware 1.0. That said, your deep_sleep code still can be integrated, but you might have to...

I'd suggest we add the logic for determining click | long press | double-click in the firmware, and instead of sending a counter, we send explicit events. Something like this:...

> The second button idea is nice, but I would need to know which GPIO pins to use Nah, don't make it all the way to the actual hardware. Just...

Basically, make it so the app developers don't have to think much about the hardware. @josancamon19 would appreciate it if you make his life easier. :-)

I was looking at the firmware_1.5 and how that code deals with buttons, and I noticed it uses k_work_reschedule to deal with the delays instead of the way you are...

Btw, you'll have to merge with https://github.com/BasedHardware/Omi/pull/590

@koconder can you look at what might be happening here? :-/

Saw few changes that slipped through the merge, which don't seem to be related to your code. Please revert them. Also, few other nitpicks here and there. Also, can you...

And sorry I've been too nitpicky