syntax icon indicating copy to clipboard operation
syntax copied to clipboard

Published 20 hours ago • verified publisher icon framer

Updated syntax theme?

Open markmals opened this issue 6 years ago • 9 comments

I would love an updated version of this syntax theme to match the new theme found on the API website and in Framer Playground!

Side-by-side for example:

Screen Shot 2019-05-10 at 3 44 54 PM

markmals avatar May 11 '19 01:05 markmals

After seeing the new Framer Playground, I really hoped that Framer Syntax is getting that cool color scheme as well!

matepapp avatar May 15 '19 19:05 matepapp

@jornvandijk Apologies if you're not the appropriate person to ask about this, but I'd be happy taking a stab at adding a dark and light update that matches the playground theme. I'm happy holding off, if that's something you're already actively pursing.

balanceiskey avatar May 20 '19 14:05 balanceiskey

Some initial progress, should have more before this week's up:

image

balanceiskey avatar May 21 '19 02:05 balanceiskey

and is it going to work with .tsx files as well?

matepapp avatar May 21 '19 08:05 matepapp

@matepapp, yep absolutely. I’m using the existing tsx examples to verify.

balanceiskey avatar May 21 '19 13:05 balanceiskey

Alright, I'm going to back off for now as it seems to mostly be working. If others would like try it out I think these steps will get you there (Note, you may need to uninstall your existing Framer syntax plugin, not sure):

  • Install: vsce (npm i -g vsce / yarn global add vsce)
  • Clone changes from fork: git clone [email protected]:balanceiskey/syntax.git
  • Run vsce package inside the cloned fork which will produce a vsix file
  • In VSCode, from the command palette (cmd-shift-p) you can hunt for vsix which will give you give you Install from VSIX as an option. Pick it and navigate to the vsix file that was generated.

Should be all set. Note, I'm happy to accept PRs and tweaks to my fork if you find things missing (which they absolutely are as both the original syntax file and this one are geared very heavily toward JS/TS). That said, if there's a desire to bring this into the mainline repo here, I'm more than happy to post as a PR to start making changes.

balanceiskey avatar May 22 '19 13:05 balanceiskey

Check out #11, this falls in line with my thought around this issue.

framer-vscode@2x

austincondiff avatar May 29 '19 17:05 austincondiff

Feelin' good in the daylight:

Kapture 2019-05-29 at 21 07 23

balanceiskey avatar May 30 '19 02:05 balanceiskey

And if you’re looking for the vim version: https://github.com/balanceiskey/vim-framer-syntax

balanceiskey avatar Jun 26 '19 22:06 balanceiskey