Default save data

[allengblack]

Not a deal breaker but just something to be aware of: it created a folder with the default name in the convoy.json file on MacOS but this won't work on Windows.

[danvixent]

@allengblack sorry i don't get what you mean.

[mykeels]

@danvixent the <insert-database-dsn> folder name was used because it was copied from the convoy.example.json file.

Such a folder name seems to work in Unix environments, but will not work on Windows.

We wonder if Convoy should prevent such dsn strings by default.

[danvixent]

I see, the config you ran convoy has the in-memory db type, we use badger for that. The dsn needs to be changed to something that suits you e.g convoy_db. The <insert-database-dsn> was just a placeholder in the example config.

Given this, i wonder if preventing it based on OS type is something we should consider cc @Subomi

[subomi]

Ah. Got it. We should sanitise the input to support Unix & Windows.