Mindaugas Vinkelis

> We could make it the exporter's responsibility to dedup and sort metric attributes instead of doing it in the SDK. I'm working on same issue, and I think it's...

I would love this to be landed... so I could remove "fix" in my own exporter implementation... :)

Thanks for review! Here's a stress test results (I ran them for a while to stabilize a bit): main branch - metrics_counter ~4.8M iter/sec expand Throughput: 4,784,400 iterations/sec Throughput: 4,781,200...

removed redudant check from `histogram.rs` and `exponential_histogram.rs`. I think it's not possible to get `infinite` or `nan` when doing conversion from integer. ``` let f_value = measurement.into_float(); if f_value.is_infinite() ||...

I was wrong regarding f64 NaN and Infinity, because actual type can be f64, and user can pass in anything he likes :) Also it looks like this check is...

Thanks for measuring it and sharing your results! I did more stress tests and indeed it looks histograms are a bit slower. Anyway, I finally understood where the issue was....

Sure,I'll definitely create separate tickets for there optimizations, but before I do that, I want to make sure `ValueMap` can be applied to all metrics (measure and collection phase). This...

> histogram: main=12.7 pr=8.1 This is insane difference... I wonder why this is so different on your platform compared to mine. I wrote a script `run_stress.sh` ```bash #!/usr/bin/env bash for...

@cijothomas and @lalitb thanks for sharing your results! I updated code by making it look as close as possible to what it was before (preserving existing bugs). Unfortunatelly I cannot...

I just ran tests on another computer Stress tests: counter 12.7 (main) --> 18.3 (PR) histogram 12.6 (main) --> 11.4 (PR) Here's the script that I used: ```bash #!/usr/bin/env bash...