shards icon indicating copy to clipboard operation
shards copied to clipboard

Inputing invalid Timeout param in HTTP client shards should result in error containing line/column info

Open ccfontes opened this issue 2 years ago • 0 comments

Describe the bug If we set an invalid Timeout like this:

"foo" | Http.Delete("http://<url>", Timeout: -1) | Log

error thrown leaks Rust error message without .shs line/column info:

thread '<unnamed>' panicked at 'overflow when adding duration to instant', library/std/src/time.rs:408:33
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: Rust panics must be rethrown
zsh: abort      shards new test.shs

Issue affects other HTTP client method shards in the same way, namely:

  • Http.Post
  • Http.Put
  • Http.Patch
  • Http.Get
  • Http.Head

Expected behavior Inputting invalid Timeout parameter to Http.Delete should result in error containing line/column info where the error occurs in the .shs script.

ccfontes avatar Oct 31 '23 09:10 ccfontes