solid_errors icon indicating copy to clipboard operation
solid_errors copied to clipboard

support ruby 3.4.0 style backtrace string

Open kuboon opened this issue 10 months ago • 1 comments

Since ruby 3.4.0, backtrace string format has changed to use single quote instead of backtick. https://github.com/ruby/ruby/commit/25d74b9527cd525042ad0b612b794fa331d3a318 https://bugs.ruby-lang.org/issues/16495

kuboon avatar Jan 28 '25 12:01 kuboon

passed on my repo https://github.com/kuboon/solid_errors/actions/runs/13322147541

kuboon avatar Feb 14 '25 03:02 kuboon

For anyone waiting for this to be merged, as a quick hack you can put this into the solid_errors.rb initializer:

ActiveSupport.on_load(:after_initialize) do
  SolidErrors::BacktraceLine.send(:remove_const, :INPUT_FORMAT)
  SolidErrors::BacktraceLine.const_set(:INPUT_FORMAT, %r{^((?:[a-zA-Z]:)?[^:]+):(\d+)(?::in [`']([^']+)')?$})
end

daniel-rikowski avatar May 26 '25 10:05 daniel-rikowski

@fractaledmind Thank you for approving. Could you merge this?

kuboon avatar Jun 09 '25 03:06 kuboon

Live in v0.7.0 now. Thanks

fractaledmind avatar Jun 11 '25 15:06 fractaledmind