fractaledmind
Introduce ability to view resolved errors and delete them
Sorry it took so long to circle back around to this! Hopefully with the release of Rails 7.2, backporting a patch will no longer be needed to run this in prod.
This introduces a new collection route at /errors/resolved that displays an index view of resolved errors.
On the show and index views, the Resolve Error button will be replaced with a Delete Error button when showing resolved errors. The deletion action checks that the error is in fact resolved before proceeding with the deletion.
In addition to the button, I added a small tag next to the error id on the show page indicating its status as either open or resolved so the user has a little more context when on a single error's page.
In order to make this useful, we need some way of navigating to the resolved errors index page (and back). This could be tabs or simply a link or button somewhere. As there is currently no top-level navigation for the site, I wanted to check with you before unilaterally introducing something like that. Maybe just a link for now?
Screenshots
Error row appearance in resolved index view:
Show page for an error that has already been resolved:
closes #4
This is lovely! Thank you. I'm presently quite busy, but I am trying to carve out time to properly review this and merge and release. But first pass looks good
Thanks for the review!
I have pushed a commit that I believe addresses all of your feedback. Additionally I have pushed a second commit that adds a toggle to the top right of the index page allowing you to switch between resolved and unresolved index views. Screenshot below.
Lovely. I want to make a few small tweaks. I'll try to carve out time next week. This is excellent tho. Thank you for this!