solid_errors icon indicating copy to clipboard operation
solid_errors copied to clipboard

Support errors happening in ActiveJob (solid_queue, sidekiq, ...)

Open stillhart opened this issue 1 year ago • 5 comments

It would be nice if solid_errors supports ActiveJob. Sentry-Rails could be a good resource of inspiration.

https://github.com/getsentry/sentry-ruby/blob/master/sentry-rails/lib/sentry/rails/active_job.rb https://github.com/getsentry/sentry-ruby/blob/master/sentry-rails/lib/sentry/rails/railtie.rb

stillhart avatar Apr 15 '24 07:04 stillhart

Or is this the job of the background worker such as solid_queue? If so, I can open an issue in solid_queue

stillhart avatar Apr 15 '24 08:04 stillhart

@stillhart I came up with simple integration for ActiveJob (tested with SolidQueue)

https://gist.github.com/defkode/3da234167d1a7bc18a46ff2e700c4d65

defkode avatar May 09 '24 05:05 defkode

@fractaledmind Been working on my own error reporter too(cause why not 😄) and stumbled on this. Opened up https://github.com/rails/rails/pull/53201 to hopefully fix this and cut down on monkey patching. Action Cable may need something too but havent tested it yet.

npezza93 avatar Oct 05 '24 15:10 npezza93

Is this solved in SolidQueue? https://github.com/rails/solid_queue/pull/373#issuecomment-2480532426

kuboon avatar Feb 28 '25 07:02 kuboon

Yep

npezza93 avatar Feb 28 '25 14:02 npezza93