git-passport icon indicating copy to clipboard operation
git-passport copied to clipboard

Handle SSH urls better and avoid race conditions when setting git local configs

Open twillard opened this issue 7 years ago • 3 comments

Hi! This is a simple pull request fixing a couple issues I had locally when using this tool.

  1. The SSH urls from github and elsewhere (ie. [email protected]:project/path/thing.git) weren't handled well by urllib without an explicit ssh:// scheme on the front, so to handle this I simply check if the parse failed, tack on a ssh:// and try again.

  2. I got race conditions trying to set username and email without adding the git_process.wait() to the get_config method.

twillard avatar Apr 03 '17 19:04 twillard

This should address at least some of issue #31

twillard avatar Apr 03 '17 19:04 twillard

And issue #37

twillard avatar Apr 03 '17 19:04 twillard

This worked perfect for me. Would be nice to have it merged (or forked by someone with more time for PRs).

skaldarnar avatar Apr 12 '17 13:04 skaldarnar