git-passport icon indicating copy to clipboard operation
git-passport copied to clipboard

Consecutive passport numbering

Open holocronweaver opened this issue 10 years ago • 2 comments

Is it necessary that the passport sections be consecutively numbered? If so, this could cause some tedium when removing an early entry in a long list of passports and having to -1 most of the sections.

holocronweaver avatar Jan 29 '15 22:01 holocronweaver

That's a good point - and to be honest I didn't think about a scenario where one would remove an early passport entry ^^. So I can't give you an answer right off the bat. I'll check this during the next couple of days. However I thought about replacing the numbering with the service name instead (e.g. [passport "github"]) anyways, but wasn't quite convinced to go that route.

frace avatar Jan 30 '15 00:01 frace

I figured it isn't really an issue because the numbering is used as an identifier to avoid duplicates inside the configfile. While parsing the passports get enumerated anyways. What happens if a user would remove a passport is that the numbering on the selection dialog does not match the identifier inside the configfile anymore. But as I said that doesn't have any impact on the result. However it's not a good solution.

frace avatar Feb 04 '15 14:02 frace