ftp directory handling doesn't seem to work properly, sometimes results in multiple same name folders

[skygunner]

ftp directory handling doesn't seem to work properly, especially try to upload a folder, which would normally create the folder and cwd into it. But the current behavior is upload a folder will usually create it, but CWD into it will fail.

Manually create a folder, then cdw into it works.

This sometimes results in multiple same name folders due to the client retry creating the folder. Then if delete the folders sometimes you would delete the wrong folder due to client side caching maybe.

[xtagon]

I've traced it to here:

https://github.com/mharris717/ember-drag-drop/blob/687f7debed01f4ab38ee893748c87dfc74b23779/app/models/coordinator.js#L15-L21

[dgavey]

Funny, I thought we had refactored all of these out. I'll try and get it fixed soon. Of course, PR's are always welcome.

[dgavey]

I don't think that model is even getting used anymore. That's legacy code.

[xtagon]

Hmm that's funny. I'm using 0.6.3 in my package.json and yarn.lock:

ember-drag-drop@^0.6.3:
  version "0.6.3"
  resolved "https://registry.yarnpkg.com/ember-drag-drop/-/ember-drag-drop-0.6.3.tgz#65e2adfffd427875a0fb2e9f15f470dcad2e5d3d"
  integrity sha512-rVrJW66IjFdujdbxEm24lX8XbaqMdGyqIQsF5iEOUlxHttNA1Fyqr8tXb2dL5VSAl32jv9WhLuGBpsOPMlgvBQ==
  dependencies:
    ember-cli-babel "7.1.3"
    ember-jquery-legacy "^1.0.0"

which is the latest version on the releases page right now.

[xtagon]

Always happy to help out with a PR but in this case I don't really understand how that code is used or how to safely remove it.

[dgavey]

No problem, yeah I need to look into this a bit more. I'm sure we don't need this model anymore, but I need to verify that.

[RobbieTheWagner]

@dgavey do you guys still need help removing these? I'm getting the warnings in my code.

[bensane]

Any update on this depreciation refactor?

[RobbieTheWagner]

@dgavey please let me know if you need help removing these.

[dgavey]

@rwwagner90 If you want to create a PR for this, I'd happily merge and release a new version.

[RobbieTheWagner]

@dgavey not sure if this works or not, but should fix the deprecation https://github.com/mharris717/ember-drag-drop/pull/180

[xtagon]

Appears to be fixed in https://github.com/mharris717/ember-drag-drop/releases/tag/v0.9.0-beta.0 but it says once it's been declared stable there will be an 0.9 release, but that was in 2021. Is this project dead?

[RobbieTheWagner]

@dgavey @mharris717 would you be interested in transferring this to adopted-ember-addons or adding some of us as maintainers here?

[dgavey]

Yes, but I don't own the repo. So I can't transfer it to you. I would suggest forking it instead and republishing, then I can shut this down and point to a different one. Maybe NPM can somehow also point to the new repo, not sure.

[RobbieTheWagner]

Do you have any contact with @mharris717? Would he be willing to transfer it?

[dgavey]

I don't have any contact with him or ability to contact him anymore.