XboxKeyboardMouse icon indicating copy to clipboard operation
XboxKeyboardMouse copied to clipboard

Recreating the Configuration, any suggestions?

Open CallumCarmicheal opened this issue 6 years ago • 7 comments

Im in the process of recreating the configuration system while working on the new GUI. As of the current system we are using INI's which are not serialized and this makes it a pain to use while programming.

Im thinking of recreating the config to make it look and seem cleaner, are there any suggestions in which format we should use. Im currently thinking json or yml.

CallumCarmicheal avatar May 06 '18 21:05 CallumCarmicheal

Im currently leaning towards yaml, any one got any objections to this?

CallumCarmicheal avatar May 09 '18 15:05 CallumCarmicheal

There's generally more support for JSON so I'm a JSON fan. Doesn't matter, do whatever you want to learn.

fqlx avatar May 10 '18 16:05 fqlx

@fqlx i know both was just curious on input from the community but it seems they dont mind. I guess we can go with json.

CallumCarmicheal avatar May 10 '18 17:05 CallumCarmicheal

I know .NET does good XML serialization out of the box which can be utilized with minimal effort. I was able to do it quickly per discussion at https://github.com/fqlx/XboxKeyboardMouse/issues/60 but backed out. If we're seriously considering the ClickOnce approach (with a likely-required update to where things get saved anyway), IMO that would be a great opportunity to switch formats too. :)

DavidRieman avatar May 15 '18 04:05 DavidRieman

  • XML files definitely end up larger than the .ini files, but if we're not saving millions of files, this is negligible.
  • Hundred less lines of code; easy to maintain going forward.
  • Standard .NET references rather than external dependencies/licenses/etc.

Anyway, both serialization and ClickOnce are both areas I'd be happy to contribute as well and would fit the time blocks I have lately - so if there's one of those you want to give up, I'd be happy to take it on.

DavidRieman avatar May 15 '18 04:05 DavidRieman

@DavidRieman Im not quite thinking about how hard it is to implement because almost all configuration libraries support serialization its more user friendly should they need to manually edit the config for what ever reason, does ClickOnce support nuget?

CallumCarmicheal avatar May 16 '18 10:05 CallumCarmicheal

Yes, ClickOnce handles dependencies that were fetched through NuGet.

DavidRieman avatar May 21 '18 06:05 DavidRieman