linux-egradjani icon indicating copy to clipboard operation
linux-egradjani copied to clipboard

Published 20 hours ago • verified publisher icon fpopic

Dockerize

Open fpopic opened this issue 1 year ago • 2 comments

Fixes #3

TODO

  • [ ] Add CI that build docker image and pushes to a registry
  • [ ] Add repo versioning with git tag
  • [ ] Update Readme

fpopic avatar Oct 31 '23 06:10 fpopic

Each RUN creates another layer and there is no need to do that. I would recommend using boolean && to merge multiple commands into a single chain that should fail (and short-circuit rest of the execution) in case of an error.

dkorunic avatar Jan 15 '24 09:01 dkorunic

Each RUN creates another layer and there is no need to do that. I would recommend using boolean && to merge multiple commands into a single chain that should fail (and short-circuit rest of the execution) in case of an error.

yes agree, didn't have time to make it work first and then optimize it (split builder from runtime image using multi-staged images and reduce amount of layers). If you wanna take over that task and contribute, feel free :)

fpopic avatar Jan 24 '24 09:01 fpopic