fplll icon indicating copy to clipboard operation
fplll copied to clipboard

Add continuous integration tests with SageMath (multi-platform)

Open mkoeppe opened this issue 5 years ago • 9 comments

See https://trac.sagemath.org/ticket/29091

Preview of a successful run on raspbian-buster-armhf-standard at ​https://github.com/mkoeppe/fplll/runs/805921434

mkoeppe avatar Jun 25 '20 17:06 mkoeppe

I think a five hour wait time for CI is asking a bit too much. Also, this should be for FPyLLL not FPLLL?

malb avatar Jun 26 '20 17:06 malb

You can configure it to run only on pull requests and tags, rather than on every commit. See commented out stuff at the beginning of the file.

mkoeppe avatar Jun 26 '20 17:06 mkoeppe

Here's a better version. Does not use a private repository any more (gets a branch from trac.sagemath.org instead), runs on pull requests and tags only, and adds macOS testing (homebrew + conda)

mkoeppe avatar Jul 04 '20 15:07 mkoeppe

Codecov Report

Merging #433 into master will increase coverage by 4.52%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   68.54%   73.06%   +4.52%     
==========================================
  Files          67       70       +3     
  Lines        4994     6549    +1555     
==========================================
+ Hits         3423     4785    +1362     
- Misses       1571     1764     +193     
Impacted Files Coverage Δ
fplll/pruner/pruner_optimize_tp.cpp 35.00% <0.00%> (-65.00%) :arrow_down:
fplll/hlll.h 58.97% <0.00%> (-41.03%) :arrow_down:
fplll/pruner/pruner_optimize.cpp 66.00% <0.00%> (-34.00%) :arrow_down:
fplll/householder.h 68.64% <0.00%> (-31.36%) :arrow_down:
fplll/pruner/pruner_cost.cpp 73.11% <0.00%> (-26.89%) :arrow_down:
fplll/pruner/pruner_optimize_tc.cpp 78.61% <0.00%> (-21.39%) :arrow_down:
fplll/pruner/pruner_util.cpp 82.25% <0.00%> (-17.75%) :arrow_down:
fplll/pruner/pruner_prob.cpp 92.42% <0.00%> (-7.58%) :arrow_down:
fplll/nr/nr_Z_d.inl 0.00% <0.00%> (ø)
fplll/nr/nr_rand.inl 100.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d10963a...b8ee002. Read the comment docs.

codecov[bot] avatar Jul 05 '20 20:07 codecov[bot]

We've switched to GitHub Actions now. I'd be up for merging this triggered manually only, i.e. on workflow_dispatch.

malb avatar Nov 19 '20 15:11 malb

We've switched to GitHub Actions now. I'd be up for merging this triggered manually only, i.e. on workflow_dispatch.

Sounds good. Would you like me to update the pull request?

mkoeppe avatar Nov 20 '20 19:11 mkoeppe

That would be great!

malb avatar Nov 21 '20 12:11 malb

Oh, another thing: shouldn't this be against FPyLLL? Typically, we release new versions of FPLLL and FPyLLL together and the latter depends on the former.

malb avatar Nov 21 '20 12:11 malb

Oh, another thing: shouldn't this be against FPyLLL? Typically, we release new versions of FPLLL and FPyLLL together and the latter depends on the former.

OK, I'll send you a pull request against fpylll and update this one. You can then decide whether you want both or only one of them.

mkoeppe avatar Nov 21 '20 19:11 mkoeppe